Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict LFO Workflow Pages from Being Visible for SFO #547

Open
5 tasks
ayeshmcg opened this issue Feb 6, 2025 · 3 comments
Open
5 tasks

Restrict LFO Workflow Pages from Being Visible for SFO #547

ayeshmcg opened this issue Feb 6, 2025 · 3 comments
Labels
Task For work that doesn't meet the requirements of a user story

Comments

@ayeshmcg
Copy link

ayeshmcg commented Feb 6, 2025

Describe the task

Currently, the following pages:

  • Review Facilities List
  • Facility Table
  • Review Facility Information
  • End of Facility Report
  • Operation Review Summary
    are part of the LFO workflow. However, these pages should not be visible when the operation type is SFO.

Dev Checklist

  • Move all these pages into a /lfo folder to make it easier to filter and restrict them based on the operation type.
  • Remove LFO-specific breadcrumbs from navigation.
  • Identify where the check should be added in withRulesAppliedReport.ts.
  • Implement logic to restrict visibility of these pages when the operation type is SFO.
  • Ensure the restriction does not affect other reports or workflows.
@ayeshmcg ayeshmcg added Backlog Refinement Tickets that require further refinement Task For work that doesn't meet the requirements of a user story labels Feb 6, 2025
@ayeshmcg
Copy link
Author

ayeshmcg commented Feb 6, 2025

@shon-button I created this ticket to block certain pages when operation type is SFO.
cc: @patriciarussellCAS

@patriciarussellCAS
Copy link

Thanks @ayeshmcg - I assumed that we were setting up conditions to ONLY show the LFO pages when the Operation Type = LFO, but whichever way makes sense to ensure only the correct operation type see's the relevant pages works for me.

@ayeshmcg
Copy link
Author

ayeshmcg commented Feb 6, 2025

@patriciarussellCAS These pages are currently visible in the LFO workflow when a user clicks "Continue" or accesses them via the task list. However, a user can manually copy the link from an LFO operation and replace it with an SFO operation ID to access the pages.

When SFO users follow the normal flow (i.e., clicking through the UI without modifying the URL), they do not see these pages.

@rdromey rdromey removed the Backlog Refinement Tickets that require further refinement label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task For work that doesn't meet the requirements of a user story
Projects
None yet
Development

No branches or pull requests

3 participants