fix: add buffer peer dependency #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
jleach
force-pushed
the
fix/update-pkg-vers
branch
from
77735a2 to
26a38b4
Compare
|
bryce-mcmath
reviewed
Feb 2, 2024
| @@ -4151,7 +4151,7 @@ __metadata: | |||
| react-native-keychain: ^8.1.1 | |||
| react-native-localize: ^2.2.4 | |||
| react-native-orientation-locker: "*" | |||
| react-native-permissions: ^3.8.4 | |||
| react-native-permissions: ^4.0.1 | |||
There was a problem hiding this comment.
Are we sure we want to go up a major version here?
There was a problem hiding this comment.
That's not my change. It comes from Bifold. But I can test it on a fresh install tomorrow and know better.
bryce-mcmath
approved these changes
Feb 2, 2024
jleach
added a commit
that referenced
this pull request
Mar 13, 2025
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the buffer package which is required as a peer dependency and update the Bifold packages.