Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch OCA references of credential_support_url to issuer_url #2337

Open
knguyenBC opened this issue Jan 8, 2025 · 1 comment
Open

Switch OCA references of credential_support_url to issuer_url #2337

knguyenBC opened this issue Jan 8, 2025 · 1 comment

Comments

@knguyenBC
Copy link

knguyenBC commented Jan 8, 2025

Background

When a proof request is received and the user does not have the credential, the wallet uses credential_support_url from OCA as the hyperlink for the "Get this credential" button. This is counter intuitive as that credential_support_url is meant to be the hyperlink to the support url (i.e. the contact us page or email) for the credential. It is meant to be accompanied by the credential_help_text (and it's text display). This is defined in the credential design guide: https://bcgov.github.io/digital-trust-toolkit/docs/resources/guides/credential-ux-guide#credential-meta-information

This is causing some confusion with people building their own OCA bundle.

Acceptance Criteria

Switch the reference from credential_support_url to issuer_url

@knguyenBC
Copy link
Author

knguyenBC commented Jan 8, 2025

  • LCRB seem to have built their OCA to match how BC Wallet is currently referencing credential_support_url. i.e. their credential_support_url overlay links to the issuance page. However, that link also has a reference to their contact us information so works both ways. Same with their issuer_url.
  • The student card OCA is built to match the credential design guide.
  • Person credential also uses the same URL for both metadata
  • LSBC has their credentials to use the same URL for both metadata.
  • Transcriber credential doesn't have the metadata populated
  • LTSA also uses the same URL for both metadata
  • Business card doesn't have the metadata populated
  • Mines don't have the metadata populated

Conclusion

  • a possible minor impacts for LCRB but everything else is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant