Skip to content

PIMS-2307 Remove Watch Agency Response Type #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Apr 24, 2025

🎯 Summary

PIMS-2307
Recommend this is reviewed after PIMS-2275 is merged. Will keep in draft until then.

Changes

  • Remove Watch value from enums in frontend and backend
  • Adjust notification generation area to look for Subscribe instead of NOT (watch or unsubscribe)
  • Create migration that moves all Watch responses to Subscribe responses. After looking at PROD to see how Watch is being used, it seems like admins occasionally attempt to use it when an agency is interested in a project. Unfortunately, Watch status acts more like Unsubscribe status at the moment. This should bring the attempted use closer to the intended behaviour.

Testing

  • Make sure you have parent agencies and child agencies with emails and Send Notifications checked in your local database.
  • Start a new project and move it to ERP. There should be agencies in the Agency Response table when the project is created.
  • See that Watch is no longer an option when trying to manually change the response.
  • See that emails are queued for expected agencies.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 2946. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 2946. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant