Setup Snackbar Provider #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24 +/- ##
===========================================
+ Coverage 30.37% 31.32% +0.95%
===========================================
Files 27 27
Lines 270 265 -5
Branches 52 49 -3
===========================================
+ Hits 82 83 +1
+ Misses 188 182 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jadmsaadaot
reviewed
Aug 6, 2024
| })); | ||
|
|
||
| // Helper function to notify with different severities | ||
| export const notify = { |
jadmsaadaot
reviewed
Aug 6, 2024
| }; | ||
|
|
||
| const ConfirmationDialog: React.FC<ConfirmationDialogProps> = ({ isOpen, title, description, onConfirm, onCancel }) => { | ||
| const ConfirmationDialog: React.FC<ConfirmationDialogProps> = ({ |
There was a problem hiding this comment.
shouldn't we be using this component here https://mui.com/material-ui/react-snackbar/
jadmsaadaot
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Setup zustand snackbar provider
-Setup notify function