Create tables and migrations #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadmsaadaot
requested review from
saravanpa-aot,
nitheesh-aot,
dinesh-aot and
djnunez-aot
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #17 +/- ##
============================================
+ Coverage 31.42% 79.77% +48.35%
============================================
Files 22 24 +2
Lines 245 544 +299
Branches 54 0 -54
============================================
+ Hits 77 434 +357
+ Misses 152 110 -42
+ Partials 16 0 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dinesh-aot
reviewed
Jul 29, 2024
|
|
||
| def upgrade(): | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| op.create_table('account', |
There was a problem hiding this comment.
Should the table names be singular or plural
There was a problem hiding this comment.
changed to plural
saravanpa-aot
approved these changes
Jul 29, 2024
| __tablename__ = 'role' | ||
|
|
||
| id = Column(db.Integer, primary_key=True, autoincrement=True) | ||
| role_name = Column(db.String(50), nullable=False) |
There was a problem hiding this comment.
whats the role like ? not the keycloak role rite? can you add more comments here plz...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the result of https://docs.google.com/spreadsheets/d/1E1EH5Sq2W9Y0Qwpjbo6va7W9VTE_RNu9M5_pTCo4DoY/edit?gid=0#gid=0 from https://apps.nrs.gov.bc.ca/int/jira/browse/EPICSYSTEM-206
I created the tables and the migrations