Merge pull request #193 from djnunez-aot/bug-fix-notes

Fix notes api - add post_dump method

submit-api/src/submit_api/schemas/submission_item_note.py

@@ -3,7 +3,7 @@
 Manages the package
 """
 
-from marshmallow import EXCLUDE, Schema, fields, pre_dump
+from marshmallow import EXCLUDE, Schema, fields
 
 
 class SubmissionItemNote(Schema):
@@ -18,13 +18,13 @@ class Meta:  # pylint: disable=too-few-public-methods
     note = fields.Str(data_key="note")
     item_id = fields.Int(data_key="item_id")
     created_date = fields.DateTime(data_key="created_date")
-    created_by = fields.Str(data_key="created_by")
+    created_by = fields.Method('get_submitted_by')
 
-    @pre_dump
-    def get_submitted_by(self, obj, **kwargs):
-        """Get created_by."""
-        obj.created_by = obj.created_by_user.account_user.full_name if obj.created_by_user else None
-        return obj
+    def get_submitted_by(self, obj):
+        """Get submitted by."""
+        submitted_by = obj.created_by_user.account_user.full_name \
+            if obj.created_by_user and obj.created_by_user.account_user else None
+        return submitted_by
 
 
 class PostSubmissionItemNote(Schema):