From 1f880ea4a0f54c80f71781b1dc72ce81b54a3c3d Mon Sep 17 00:00:00 2001 From: David Nunez <103138766+djnunez-aot@users.noreply.github.com> Date: Tue, 25 Feb 2025 11:32:27 -0500 Subject: [PATCH 1/6] setup staff ui touch ups for tables --- .../Submission/DocumentRow/index.tsx | 14 ++++++++------ .../components/Submission/ItemsTable/index.tsx | 18 +++++++++++++----- .../StaffSubmissionItemTableRow.tsx | 11 ++++++++--- 3 files changed, 29 insertions(+), 14 deletions(-) diff --git a/submit-web/src/components/Submission/DocumentRow/index.tsx b/submit-web/src/components/Submission/DocumentRow/index.tsx index 3545234a..5a5a831c 100644 --- a/submit-web/src/components/Submission/DocumentRow/index.tsx +++ b/submit-web/src/components/Submission/DocumentRow/index.tsx @@ -55,7 +55,7 @@ export default function DocumentRow({ return ( <> *": { borderBottom: "unset" } }}> - + - {submitted_by || ""} - + + {submitted_by || ""} + + {version} - setExpanded(!expanded)}> + setExpanded(!expanded)} sx={{ p: 0 }}> - + - + - + - Uploaded by - Version - Status - Actions + + Uploaded by + + + Version + + + Status + + + Actions + diff --git a/submit-web/src/components/Submission/SubmissionItemTableRow/StaffSubmissionItemTableRow.tsx b/submit-web/src/components/Submission/SubmissionItemTableRow/StaffSubmissionItemTableRow.tsx index 76aa2d16..7282fce8 100644 --- a/submit-web/src/components/Submission/SubmissionItemTableRow/StaffSubmissionItemTableRow.tsx +++ b/submit-web/src/components/Submission/SubmissionItemTableRow/StaffSubmissionItemTableRow.tsx @@ -91,7 +91,7 @@ export default function StaffSubmissionItemTableRow({ return ( <> - + + - + - + Date: Tue, 25 Feb 2025 12:42:03 -0500 Subject: [PATCH 2/6] update other parts of the ui --- submit-web/src/components/Submission/DocumentRow/index.tsx | 2 +- .../SubmissionItemTableRow/StaffSubmissionItemTableRow.tsx | 6 +----- .../components/SubmissionItem/InternalDocuments/Rows.tsx | 2 +- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/submit-web/src/components/Submission/DocumentRow/index.tsx b/submit-web/src/components/Submission/DocumentRow/index.tsx index 5a5a831c..4924f650 100644 --- a/submit-web/src/components/Submission/DocumentRow/index.tsx +++ b/submit-web/src/components/Submission/DocumentRow/index.tsx @@ -99,7 +99,7 @@ export default function DocumentRow({ diff --git a/submit-web/src/components/Submission/SubmissionItemTableRow/StaffSubmissionItemTableRow.tsx b/submit-web/src/components/Submission/SubmissionItemTableRow/StaffSubmissionItemTableRow.tsx index 7282fce8..004aabe4 100644 --- a/submit-web/src/components/Submission/SubmissionItemTableRow/StaffSubmissionItemTableRow.tsx +++ b/submit-web/src/components/Submission/SubmissionItemTableRow/StaffSubmissionItemTableRow.tsx @@ -121,11 +121,7 @@ export default function StaffSubmissionItemTableRow({ /> - + - + Date: Tue, 25 Feb 2025 13:04:58 -0500 Subject: [PATCH 3/6] fix proponent side --- .../ProponentSubmissionItemTableRow.tsx | 19 ++++++++++--------- .../StaffSubmissionItemTableRow.tsx | 11 ++--------- 2 files changed, 12 insertions(+), 18 deletions(-) diff --git a/submit-web/src/components/Submission/SubmissionItemTableRow/ProponentSubmissionItemTableRow.tsx b/submit-web/src/components/Submission/SubmissionItemTableRow/ProponentSubmissionItemTableRow.tsx index 8fe9ba13..52a2fd4b 100644 --- a/submit-web/src/components/Submission/SubmissionItemTableRow/ProponentSubmissionItemTableRow.tsx +++ b/submit-web/src/components/Submission/SubmissionItemTableRow/ProponentSubmissionItemTableRow.tsx @@ -47,7 +47,7 @@ export default function ProponentSubmissionItemTableRow({ const submissionPackage = queryClient.getQueryData( getSubmissionPackageQueryOptions({ packageId: Number(submissionPackageId), - }).queryKey, + }).queryKey ); const isUpdated = useMemo(() => { @@ -55,7 +55,7 @@ export default function ProponentSubmissionItemTableRow({ const last_update_request = submissionPackage.update_requests .filter( (updateRequest) => - updateRequest.type === UPDATE_REQUEST_TYPE.UPDATE.value, + updateRequest.type === UPDATE_REQUEST_TYPE.UPDATE.value ) .sort((a, b) => dayjs(b.created_date).diff(dayjs(a.created_date)))[0]; @@ -63,9 +63,9 @@ export default function ProponentSubmissionItemTableRow({ return Boolean( item.submissions.find((submission) => dayjs(submission.created_date).isAfter( - last_update_request?.created_date, - ), - ), + last_update_request?.created_date + ) + ) ); }, [item, submissionPackage]); @@ -87,7 +87,7 @@ export default function ProponentSubmissionItemTableRow({ return ( <> - + + - + - + - updateRequest.status !== UPDATE_REQUEST_STATUS.ACCEPTED.value, + updateRequest.status !== UPDATE_REQUEST_STATUS.ACCEPTED.value ).length === 0 } > diff --git a/submit-web/src/components/Submission/SubmissionItemTableRow/StaffSubmissionItemTableRow.tsx b/submit-web/src/components/Submission/SubmissionItemTableRow/StaffSubmissionItemTableRow.tsx index 004aabe4..4c380ab9 100644 --- a/submit-web/src/components/Submission/SubmissionItemTableRow/StaffSubmissionItemTableRow.tsx +++ b/submit-web/src/components/Submission/SubmissionItemTableRow/StaffSubmissionItemTableRow.tsx @@ -27,6 +27,7 @@ import { import dayjs from "dayjs"; import { SUBMISSION_TYPE } from "@/models/Submission"; import SubmissionItemReviewConfirmation from "../SubmissionItemReviewConfirmation"; +import EmptyRow from "@/components/Projects/ProjectTable/EmptyRow"; export default function StaffSubmissionItemTableRow({ item, @@ -176,15 +177,7 @@ export default function StaffSubmissionItemTableRow({ - - - + ); } From ce7823e34f06e61a1d1c51a91f769a57c73841aa Mon Sep 17 00:00:00 2001 From: David Nunez <103138766+djnunez-aot@users.noreply.github.com> Date: Tue, 25 Feb 2025 13:32:17 -0500 Subject: [PATCH 4/6] setup status boxes --- .../ProponentSubmissionItemTableRow.tsx | 15 +++++++++------ .../StaffSubmissionItemTableRow.tsx | 15 +++++++++------ 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/submit-web/src/components/Submission/SubmissionItemTableRow/ProponentSubmissionItemTableRow.tsx b/submit-web/src/components/Submission/SubmissionItemTableRow/ProponentSubmissionItemTableRow.tsx index 52a2fd4b..6420c414 100644 --- a/submit-web/src/components/Submission/SubmissionItemTableRow/ProponentSubmissionItemTableRow.tsx +++ b/submit-web/src/components/Submission/SubmissionItemTableRow/ProponentSubmissionItemTableRow.tsx @@ -1,4 +1,5 @@ import { + Box, Link as MuiLink, TableCell, TableRow, @@ -109,12 +110,14 @@ export default function ProponentSubmissionItemTableRow({ - + + + - + + + From 0eda6f750e214f358325df2bec8d84d760fe47b4 Mon Sep 17 00:00:00 2001 From: David Nunez <103138766+djnunez-aot@users.noreply.github.com> Date: Wed, 26 Feb 2025 14:04:32 -0500 Subject: [PATCH 5/6] remove colspan instances --- .../src/components/Submission/DocumentRow/index.tsx | 10 +++++----- .../src/components/Submission/ItemsTable/index.tsx | 10 +++++----- .../ProponentSubmissionItemTableRow.tsx | 12 ++++++------ .../StaffSubmissionItemTableRow.tsx | 12 ++++++------ 4 files changed, 22 insertions(+), 22 deletions(-) diff --git a/submit-web/src/components/Submission/DocumentRow/index.tsx b/submit-web/src/components/Submission/DocumentRow/index.tsx index 4924f650..71b2ebc0 100644 --- a/submit-web/src/components/Submission/DocumentRow/index.tsx +++ b/submit-web/src/components/Submission/DocumentRow/index.tsx @@ -55,7 +55,7 @@ export default function DocumentRow({ return ( <> *": { borderBottom: "unset" } }}> - + - + {submitted_by || ""} - + {version} setExpanded(!expanded)} sx={{ p: 0 }}> - + - + - + - + Uploaded by - + Version - + Status - + Actions diff --git a/submit-web/src/components/Submission/SubmissionItemTableRow/ProponentSubmissionItemTableRow.tsx b/submit-web/src/components/Submission/SubmissionItemTableRow/ProponentSubmissionItemTableRow.tsx index 6420c414..8b763b49 100644 --- a/submit-web/src/components/Submission/SubmissionItemTableRow/ProponentSubmissionItemTableRow.tsx +++ b/submit-web/src/components/Submission/SubmissionItemTableRow/ProponentSubmissionItemTableRow.tsx @@ -88,7 +88,7 @@ export default function ProponentSubmissionItemTableRow({ return ( <> - + - - - + + + - + - + - - - + + + - + Date: Wed, 26 Feb 2025 14:12:16 -0500 Subject: [PATCH 6/6] remove other colspan misuses --- submit-web/src/components/Submission/DocumentRow/index.tsx | 2 +- .../src/components/SubmissionItem/InternalDocuments/Rows.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/submit-web/src/components/Submission/DocumentRow/index.tsx b/submit-web/src/components/Submission/DocumentRow/index.tsx index 71b2ebc0..f61c0ccc 100644 --- a/submit-web/src/components/Submission/DocumentRow/index.tsx +++ b/submit-web/src/components/Submission/DocumentRow/index.tsx @@ -99,7 +99,7 @@ export default function DocumentRow({ diff --git a/submit-web/src/components/SubmissionItem/InternalDocuments/Rows.tsx b/submit-web/src/components/SubmissionItem/InternalDocuments/Rows.tsx index 595477ac..a05102c2 100644 --- a/submit-web/src/components/SubmissionItem/InternalDocuments/Rows.tsx +++ b/submit-web/src/components/SubmissionItem/InternalDocuments/Rows.tsx @@ -21,7 +21,7 @@ export default function Rows({ return ( <> - +