Merge pull request #275 from jadmsaadaot/SUBMIT-task#345

only display review confirmation modal for staff
bcgov · Feb 1, 2025 · 0e4a227 · 0e4a227
2 parents d5e5c57 + 649acf3
commit 0e4a227
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/submit-web/src/components/Submission/DocumentRow/index.tsx b/submit-web/src/components/Submission/DocumentRow/index.tsx
@@ -11,11 +11,13 @@ import SubmissionItemReviewConfirmation from "../SubmissionItemReviewConfirmatio
 type DocumentRowProps = Readonly<{
   documentSubmission: Submission;
   submissionItem: SubmissionItem;
+  staff?: boolean;
 }>;
 
 export default function DocumentRow({
   documentSubmission,
   submissionItem,
+  staff = false,
 }: DocumentRowProps) {
   const [pendingGetObject, setPendingGetObject] = useState(false);
 
@@ -54,14 +56,18 @@ export default function DocumentRow({
             mx: 0.5,
           }}
         >
-          <SubmissionItemReviewConfirmation
-            packageId={submissionItem.package_id}
-            itemType={submissionItem.type.name}
-            onClick={openDocument}
-            bypass={Boolean(submissionItem.review_start_date)}
-          >
-            <MuiLink>{name}</MuiLink>
-          </SubmissionItemReviewConfirmation>
+          {staff ? (
+            <SubmissionItemReviewConfirmation
+              packageId={submissionItem.package_id}
+              itemType={submissionItem.type.name}
+              onClick={openDocument}
+              bypass={Boolean(submissionItem.review_start_date)}
+            >
+              <MuiLink>{name}</MuiLink>
+            </SubmissionItemReviewConfirmation>
+          ) : (
+            <MuiLink onClick={openDocument}>{name}</MuiLink>
+          )}
         </Typography>
       </SubmitTableCell>
       <SubmitTableCell align="right">{submitted_by || ""}</SubmitTableCell>

diff --git a/submit-web/src/components/Submission/SubmissionItemTableRow/StaffSubmissionItemTableRow.tsx b/submit-web/src/components/Submission/SubmissionItemTableRow/StaffSubmissionItemTableRow.tsx
@@ -159,6 +159,7 @@ export default function StaffSubmissionItemTableRow({
             submissionItem={item}
             key={`doc-row-${submission.id}`}
             documentSubmission={submission}
+            staff
           />
         ))}
       <When condition={error}>