Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scanning URLs #40

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Fix scanning URLs #40

merged 2 commits into from
Jan 29, 2025

Conversation

forman
Copy link
Member

@forman forman commented Jan 29, 2025 •
edited
Loading

Fixed an issue that prevented recursively traversing folders referred to by URLs (such as s3://<bucket>/<path>/) rather than local directory paths.

Closes #39

Checklist (strike out non-applicable):

  • Changes documented in CHANGES.md
  • Related issue exists and is referred to in the PR description and CHANGES.md
  • Added docstrings and API docs for any new/modified user-facing classes and functions
  • Changes/features documented in docs/*
  • Unit-tests adapted/added for changes/features
  • Test coverage remains or increases (target 100%)

@forman forman marked this pull request as ready for review January 29, 2025 14:25
@forman forman self-assigned this Jan 29, 2025
@forman forman merged commit 9e52cfe into main Jan 29, 2025
4 checks passed
@forman forman deleted the forman-39-fix_scanning_urls branch January 31, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@forman forman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recursive check of datasets in an S3 bucket failing
1 participant
@forman