Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react webpack example #369

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Add react webpack example #369

merged 1 commit into from
Dec 3, 2023

Conversation

Mivr
Copy link
Contributor

@Mivr Mivr commented Dec 3, 2023

Related to aspect-build/bazel-examples#276 and aspect-build/bazel-examples#83

This PR adds a react JS Webpack example using SWC for transpilation and Webpack for bundling.

Copy link

google-cla bot commented Dec 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@alexeagle
Copy link
Contributor

Looks great, thank you!

FYI I've been working the last couple days to change the existing react example to stop using react-scripts, but I'll switch it to vite/vitest so it will still be nicely orthogonal to this one.

@alexeagle alexeagle merged commit 06c9ff0 into bazelbuild:main Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants