-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to objc_provider and remove force_load_direct_deps to support rules_apple > 3.15.0 #934
Conversation
@luispadron If I can get your review that'd be fantastic 🙏 |
Thanks for getting the work started here! I think theres some left-over usage:
Do we need to upgrade rules_apple in |
@luispadron I think when I didnt change rules_apple to 3.15.0, I got build errors that rules_apple was expecting the objc_provider parameter. I would vote to drop Bazel 6 support mainly because
What do you think? If you’d think its fine to drop support for Bazel 6, I’m happy to start that PR before we let this in. |
Yeah I think it makes sense! @thiagohmcruz @gyfelton FYI in case we have some reason for keeping Bazel 6 |
Okay perfect. I can start that PR and will tag you along. I’ll likely complete it after New Years when I am back from vacation. |
⚠️ Bazel 6 support is being dropped from rules_ios starting release > 5.3.0 With new changes in rules_apple such as removal of legacy objc_provider, latest rules_apple and latest rules_ios are no longer compatible, the PR is up to fix but we need to drop support for Bazel 6 to move on with that PR due to rules_apple dropping support for Bazel 6 Additionally, @luispadron 's survey showed most of us are on Bazel 7. ## Related PRs - #934 Co-authored-by: Sarad <sarad.pant@capitalone.com>
e2e2d79
to
94f6914
Compare
When you have some time, can I get your reviews on this PR please? All the checks should pass so its ready to review. Thank you and much appreciated! 🙏 |
I don't think this was being exercised in OSS properly, I'm running CI internally pointing to this PR since we rely on the features being touched here. My first test has failed with a bunch of |
This patches in bazel-ios/rules_ios#934, which has not been merged just yet, to handle the fact that some link options were removed in bazel 8 / rules_apple 3.15+ . This also removes most properties in objc provider merging, as they were removed upstream/ in newer versions of rules_apple.
I think we got all the stuffs covered here. Anything pending to merge this? @jschear @jszumski @thiagohmcruz Thank you all again for all the reviews. I appreciate it! 🙏 |
With rules_apple removing legacy objc_providers, rules_apple > 3.15.0 is no longer compatible with rules_ios due to Remove legacy Objc provider linking support bazelbuild/rules_apple#2611
Removing force load direct deps as its no longer needed in Bazel 7 Consider removing
force_load_direct_deps_rule
in Bazel 7+ #862This PR is attempt to make rules_ios compatible with rules_apple + remove the legacy code to force load direct deps as with Bazel 7,
--incompatible_objc_alwayslink_by_default
does the same thing.