Allow frameworks parameter to be used in ios_application #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
codeman9
commented
Dec 26, 2023
codeman9
commented
- Before this change, using the "frameworks" parameter in ios_application resulted in an error: "Error in ios_application: rule(...) got multiple values for parameter 'frameworks'" because we are passing "application_kwargs" into the rules_apple rule which has the "frameworks" parameter copied over from "kwargs". Making this change actually pops the parameter from the correct dictionary which will remove the duplication error.
- Before this change, using the "frameworks" parameter in ios_application resulted in an error: "Error in ios_application: rule(...) got multiple values for parameter 'frameworks'" because we are passing "application_kwargs" into the rules_apple rule which has the "frameworks" parameter copied over from "kwargs". Making this change actually pops the parameter from the correct dictionary which will remove the duplication error.
luispadron
approved these changes
Dec 26, 2023
| minimum_os_version = "10.0", | ||
| visibility = ["//visibility:public"], | ||
| # This should automatically bake in a,b | ||
| deps = [ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.