-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce an alias for an xcframework's ios_sim_arm64
slice if available
#810
Conversation
This is a big QOL improvement! Most folks probably won't need the |
@@ -345,14 +345,13 @@ def _xcframework(*, library_name, name, slices): | |||
elif arch == "arm64": | |||
if platform_variant == "simulator": | |||
arm64_simulator_slice = name | |||
|
|||
# Skip this - it's later defined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerrymarino you added this originally, do you have any background context or know what might break that isn't covered by the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some very odd permutations of xcframeworks we handle and can try to run this code against with CI, it's unlikely all possible permutations are tested here
AFAIK it seems to create an alias to this here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When turning on arm64_simulator_use_device_deps
it gets you the option -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet one less flag to worry about
Are you ready to merge this one, @jszumski? |
If
apple.arm64_simulator_use_device_deps
is False, an xcframework providing slices forios-arm64
andios-arm64_x86_64-simulator
wouldn't select the second slice for anios_sim_arm64
build.The configuration being built had these values:
This change emits a new condtion for
//SomeFramework:SomeFramework-import-SomeFramework.xcframework-ios_simulator_arm64
that matches@build_bazel_rules_apple//apple:ios_sim_arm64
to theSomeFrameowrk.xcframework-ios-arm64_x86_64-simulator
slice.