Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove missing output_discriminator attribute usage #796

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

mattrobmattrob
Copy link
Collaborator

@mattrobmattrob mattrobmattrob commented Oct 30, 2023

Fixes #795. Bazel 7 seems to validate the usage of non-defined attributes better than Bazel 6 and lower.

Testing Bazel 7 in CI using #797. This gets us one step closer to being prepared for Bazel 7.

Fixes #795

Signed-off-by: Matt Robinson <mattrob@hey.com>
@mattrobmattrob mattrobmattrob marked this pull request as ready for review October 30, 2023 16:35
Copy link
Collaborator

@luispadron luispadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like theres other issues with Bazel 7 with transitions but this seems good to go in.

@mattrobmattrob mattrobmattrob merged commit ffc6a79 into master Oct 30, 2023
@mattrobmattrob mattrobmattrob deleted the mr/fix.output_discriminator.usage branch October 30, 2023 16:38
@luispadron luispadron mentioned this pull request Oct 30, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Bazel 7
2 participants