Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by Series #195

Open
adam-rozen opened this issue Feb 12, 2025 · 3 comments
Open

Sort by Series #195

adam-rozen opened this issue Feb 12, 2025 · 3 comments

Comments

@adam-rozen
Copy link
Contributor

Issue: Books are not sorted by series on My Books page
Expected Functionality: When sort by is set to series, books are ordered by series and their number in the series

@bayang
Copy link
Owner

bayang commented Feb 23, 2025

this sort option broke when I added the possibility to have multiple series on one book.

Series used to be a single field on the book, now it is a separate table in DB.

I can add order by series but when a book has multiple series only one will be used for sorting and that can lead to confusion in the UI.

Duplicating books that have multiple series to make them appear once per series is even more confusing.

This problem will also appear if I introduce sort by authors #106 , books with multiple authors will be sorted by one of the authors only

@adam-rozen
Copy link
Contributor Author

Yes, that is a good point. I am not a fan of either of these options either, but would still like to see this functionality return someday if possible. Perhaps we can leave this open in case someone else sees it and has a fresh approach.

In the meantime, since it does not work and is not likely to return soon, perhaps sort by author and sort by series should be hidden from the UI?

@bayang
Copy link
Owner

bayang commented Mar 5, 2025

Yes, it makes sense. I'll remove the filter since it is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants