Support for array of attachments

[pomarec]

Hi,

Thanks for the work on this package.

Is it planned to support attachmentS ?

class User extends compose(BaseModel, Attachmentable) {
  @attachments()
  declare avatar: Attachment[]
}

Best

[batosai]

Not at the moment, but I keep the idea to think about it.

Thanks

[corentinclichy]

First thanks a lot for the lib! This is really cool!
Just comment to follow this. I am really interested by multi file uploads

[batosai]

Hello,

The development is in progress :)

[batosai]

Hello,

I just released a beta version with this feature.

npm i @jrmc/adonis-attachment@beta

  @attachments({
    disk: 'minio',
    folder: 'users',
    variants: ['thumbnail']
  })
  declare files: Attachment[] | null

async update({ request, response }: HttpContext) {
    const user = await User.first()

    const avatar = request.file('avatar')
    const files = request.files('files')

    if (user) {
      if (avatar) {
        user.avatar = await attachmentManager.createFromFile(avatar)
      }

      if (files.length) {
        user.files = await attachmentManager.createFromFiles(files)
      }

      await user.save()
    }

    response.redirect().toRoute('home')
  }

Thank you in advance for your feedback

[pomarec]

Thank for this improvement !

I have only one pending problem :

Record.#getDirtyAttributeNamesOfAttachment() consider as valid an array of strings changing from ['bla'] to [] because isDirtyAttachment is true

Proposed solution :

          const isDirtyAttachment =
        dirtyValue instanceof Attachment ||
        (Array.isArray(dirtyValue) && dirtyValue.every((item) => item instanceof Attachment) && dirtyValue.length)  

Same for originalValue.

What do you think ?

[batosai]

Yes I missed it, I will change that.

Thanks

[batosai]

@pomarec After analyzing, in which case do you find yourself with [] ?

[batosai]

I created a new beta version.

[pomarec]

export enum NotificationType {
  notif1 = 'name_of_notif_1',
   ...
}

class User {
  declare enabledNotificationsEmail: NotificationType[]
}

[pomarec]

LGTM

[pomarec]

@batosai Do you mind fixing what I mentionned above for isDirtyAttachment and isOriginalAttachment and publish a new beta ?
Thanks in advance

[batosai]

This has been done and you have confirmed it to me 🧐

[pomarec]

I might be wrong but it seems the fix is not done for isOriginalAttachment

[batosai]

Ok, I’ll watch this as soon as possible