PhononWorkChain: add max concurrent running pw workchains
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #52 Add the `settings.max_concurrent_base_workchains` input to the `PhononWorkChain` to run only up to a maximum number of PwBaseWorkChain at the same time. This is particularly useful for low symmetry materials where many displacements are generated. This avoids to overload both the AiiDA daemon and especially the HPC. Moreover, this even allows for running on the local machine (where AiiDA is installed) this workflow.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 86.59% 86.77% +0.17%
==========================================
Files 34 34
Lines 2491 2502 +11
==========================================
+ Hits 2157 2171 +14
+ Misses 334 331 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@cpignedoli here you go! A bit late, but they say better late than never :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52
Add the
settings.max_concurrent_base_workchainsinput to thePhononWorkChainto run only up to a maximum number of PwBaseWorkChain at the same time. This is particularly useful for low symmetry materials where many displacements are generated. This avoids to overload both the AiiDA daemon and especially the HPC. Moreover, this even allows for running on the local machine (where AiiDA is installed) this workflow.