Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix code comments and variables errors #1711

Closed
wants to merge 31 commits into from
Closed

Conversation

intls
Copy link
Contributor

@intls intls commented Feb 5, 2025

What changed? Why?

Notes to reviewers

How has it been tested?

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 6:59pm

Copy link

vercel bot commented Feb 5, 2025

@intls is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Feb 5, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@dschlabach dschlabach changed the title fix: code comments and variables errors fix: fix code comments and variables errors Mar 6, 2025
@intls intls requested a review from dschlabach March 6, 2025 16:49
@intls
Copy link
Contributor Author

intls commented Mar 6, 2025

Hi Dev! @dschlabach Updated branch! Thanks!

@dschlabach
Copy link
Contributor

@intls - please take a look at the build - looks like you need to lint https://github.com/base/web/actions/runs/13703849650/job/38324204785?pr=1711

@intls
Copy link
Contributor Author

intls commented Mar 6, 2025

@intls - please take a look at the build - looks like you need to lint https://github.com/base/web/actions/runs/13703849650/job/38324204785?pr=1711

@dschlabach I don't know how to fix it, maybe better re-open PR?

@intls
Copy link
Contributor Author

intls commented Mar 6, 2025

@intls - please take a look at the build - looks like you need to lint https://github.com/base/web/actions/runs/13703849650/job/38324204785?pr=1711

@dschlabach Unfortunately I can't solve this by myself, can you help me please?

@dschlabach
Copy link
Contributor

@intls are you able to build and run lint locally?

@intls
Copy link
Contributor Author

intls commented Mar 6, 2025

@intls are you able to build and run lint locally?

@dschlabach Sorry, but I don't know how to do this.

@intls
Copy link
Contributor Author

intls commented Mar 6, 2025

@intls are you able to build and run lint locally?

@dschlabach Tried run "yarn lint --fix" command but didnt help

@intls
Copy link
Contributor Author

intls commented Mar 7, 2025

@dschlabach all done! Now lint ok! PR ready for review! Thanks!

@dschlabach
Copy link
Contributor

@intls - looks like CI is still failing. Would recommend you create a new PR because I'm not sure why this PR is causing that lint to fail

➤ YN0000: ./src/utils/hooks/useWithdrawalStatus.ts
➤ YN0000: 35:9 Error: Unsafe assignment of an error typed value. @typescript-eslint/no-unsafe-assignment
➤ YN0000: 35:28 Error: Unsafe call of an error type typed value. @typescript-eslint/no-unsafe-call
➤ YN0000: 37:36 Error: Unsafe argument of type any assigned to a parameter of type bigint | undefined. @typescript-eslint/no-unsafe-argument
➤ YN0000: 38:48 Error: Unsafe argument of type any assigned to a parameter of type bigint | undefined. @typescript-eslint/no-unsafe-argument

@intls intls closed this Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base web review To be reviewed by the Base web team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants