Publish SNS event on new alert #200

adrain-cb · 2024-01-30T02:36:19Z

Pull Request Template

Fixes Issue

Fixes #198

Changes proposed

Screenshots (Optional)

Note to reviewers

internal/alert/manager.go

ethenotethan

This looks good, just have some comments 🔥

e2e/alerting_test.go

e2e/setup.go

scripts/localstack-setup.sh

e2e/alerting_test.go

config.env.template

internal/client/sns.go

internal/metrics/metrics.go

docker-compose.yml

e2e/heuristic_test.go

e2e/setup.go

ethenotethan

Just a few knits - once those are addressed it should be good to go 💯

e2e/alerting_test.go

internal/client/sns.go

ethenotethan

LGTM 🧨

cb-heimdall · 2024-02-09T22:12:01Z

Review Error for epociask @ 2024-02-09 22:12:01 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

e2e/alerting_test.go

internal/client/sns.go

adrain-cb added 7 commits January 29, 2024 18:33

Publish SNS event on new alert

999087e

Fix linter

557cfc0

Update test client config

c1e3f97

Add e2e tests for sns event publishing

02f53a3

Fix markdownlint issues

88176f4

Fix lint issues

58d2aa0

Update markdownlint to new nde version

402ee6a

ethenotethan reviewed Feb 6, 2024

View reviewed changes

internal/alert/manager.go Outdated Show resolved Hide resolved

Address pr comments

e7a88d0

adrain-cb requested a review from ethenotethan February 7, 2024 00:55

Fix linting issues

9da9173

adrain-cb marked this pull request as ready for review February 7, 2024 19:24

adrain-cb added 3 commits February 7, 2024 12:08

Gen mocks, update node version for markdownlinter

6e7646b

Fix gosec issue

01a41a7

Fix linting issue

2851d2c

adrain-cb requested a review from megha31-cb February 7, 2024 21:19

ethenotethan reviewed Feb 8, 2024

View reviewed changes

adrain-cb added 3 commits February 8, 2024 16:11

Address most pr comments

74f2414

Add docs for sns feature

655294b

Add aws endpoint to config.env.template

1e62262

adrain-cb requested a review from ethenotethan February 9, 2024 00:26

Fix style issues

e17ab0e

ethenotethan reviewed Feb 9, 2024

View reviewed changes

e2e/alerting_test.go Outdated Show resolved Hide resolved

e2e/alerting_test.go Show resolved Hide resolved

internal/client/sns.go Show resolved Hide resolved

Address pr comments

bc97527

ethenotethan previously approved these changes Feb 9, 2024

View reviewed changes

megha31-cb reviewed Feb 14, 2024

View reviewed changes

e2e/alerting_test.go Show resolved Hide resolved

megha31-cb reviewed Feb 14, 2024

View reviewed changes

e2e/alerting_test.go Show resolved Hide resolved

megha31-cb reviewed Feb 14, 2024

View reviewed changes

internal/client/sns.go Show resolved Hide resolved

Address pr comments

546f326

adrain-cb dismissed ethenotethan’s stale review via 546f326 February 14, 2024 20:45

Merge branch 'master' into sns-client

97157e5

megha31-cb approved these changes Feb 15, 2024

View reviewed changes

adrain-cb merged commit 346ec30 into master Feb 22, 2024
12 checks passed

adrain-cb deleted the sns-client branch February 22, 2024 21:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Publish SNS event on new alert #200

Publish SNS event on new alert #200

adrain-cb commented Jan 30, 2024

ethenotethan left a comment

ethenotethan left a comment

ethenotethan left a comment

cb-heimdall commented Feb 9, 2024

Publish SNS event on new alert #200

Publish SNS event on new alert #200

Conversation

adrain-cb commented Jan 30, 2024

Pull Request Template

Fixes Issue

Changes proposed

Screenshots (Optional)

Note to reviewers

ethenotethan left a comment

Choose a reason for hiding this comment

ethenotethan left a comment

Choose a reason for hiding this comment

ethenotethan left a comment

Choose a reason for hiding this comment

cb-heimdall commented Feb 9, 2024