Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sepolia] deploy revshare contracts to sepolia #119
[sepolia] deploy revshare contracts to sepolia #119
Changes from 1 commit
3bfd841
2e357cb
c0cc316
bb37a30
38078de
14604df
d3c974f
623467a
af022f4
3465342
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
BALANCE_TRACKER_DEPLOYER
andFEE_DISBURSER_DEPLOYER
are filled in when the deploy happens?(the address of the EOA wallet deployer)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd want to allocate a new key for this - let's sync offline!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very sure where to find
PROFIT_WALLET
andOPTIMISM_WALLET
for sepolia, would love some hints on this oneThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can use what we used for Goerli (
0x5a822ea15764a6090b86b1eabffc051cec99afe9
) for both values. This is a coinbase managed keyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although if we're anyways allocating an address for deploying, might be a good idea to allocate a new one here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated it to
0x5a822ea15764a6090b86b1eabffc051cec99afe9
for now!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
owner()
in L1 ProxyAdmin https://sepolia.etherscan.io/address/0x0389E59Aa0a41E4A413Ae70f0008e76CAA34b1F3#readContractThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is correct! but we do want to eventually change these admins to being the Gnosis safes we setup so would be ideal if we just set that to be the admin to avoid another owernship transfer later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cast call --rpc-url https://base-sepolia.cbhq.net 0x4200000000000000000000000000000000000018 "owner()"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to run local test for this multisig script? I tried to pass in
--private-key $(PRIVATE_KEY)
with my own private key and using my wallet address forCB_SAFE_ADDRESS
to runsign-cb
but it throwsRevert
error.Not sure if that's the proper way to do it though