Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improve Bandclient #32

Merged
merged 2 commits into from
Feb 19, 2025
Merged

[Feature] Improve Bandclient #32

merged 2 commits into from
Feb 19, 2025

Conversation

tanut32039
Copy link
Contributor

Fixed: #XXXX

Implementation details

  • Add timeout into the object (or add it as a config)
  • fix Signing.Status that uses string

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@tanut32039 tanut32039 requested review from nkitlabs and RogerKSI and removed request for nkitlabs February 3, 2025 04:47
@RogerKSI RogerKSI self-requested a review February 19, 2025 08:30
@nkitlabs nkitlabs merged commit db08b24 into main Feb 19, 2025
2 checks passed
@nkitlabs nkitlabs deleted the improve-bandclient branch February 19, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants