[Feature] Add telemetry #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkitlabs
reviewed
Jan 26, 2025
nkitlabs
reviewed
Jan 26, 2025
added 3 commits
January 29, 2025 15:07
Kissadada
reviewed
Jan 31, 2025
Kissadada
reviewed
Jan 31, 2025
RogerKSI
reviewed
Jan 31, 2025
nkitlabs
reviewed
Feb 4, 2025
nkitlabs
reviewed
Feb 7, 2025
added 2 commits
February 7, 2025 16:14
nkitlabs
approved these changes
Feb 7, 2025
RogerKSI
requested changes
Feb 11, 2025
RogerKSI
requested changes
Feb 19, 2025
internal/relayermetrics/metrics.go
Outdated
Comment on lines
77
to
96
| // IncActiveTargetContractsCount increases the count of active target contracts. | ||
| func IncActiveTargetContractsCount() { | ||
| updateMetrics(func() { | ||
| metrics.ActiveTargetContracts.Inc() | ||
| }) | ||
| } | ||
|
|
||
| // DecActiveTargetContractsCount decreases the count of active target contracts. | ||
| func DecActiveTargetContractsCount() { | ||
| updateMetrics(func() { | ||
| metrics.ActiveTargetContracts.Dec() | ||
| }) | ||
| } | ||
|
|
||
| // IncTxCount increments the transactions count metric for a specific tunnel. | ||
| func IncTxCount(tunnelID uint64) { | ||
| updateMetrics(func() { | ||
| metrics.TxCount.WithLabelValues(fmt.Sprintf("%d", tunnelID)).Inc() | ||
| }) | ||
| } |
There was a problem hiding this comment.
- not align on plural/singular
- not align on suffix (count)
There was a problem hiding this comment.
fixed pls check again
relayer/scheduler.go
Outdated
| s.Log.Info( | ||
| "New tunnel synchronized successfully", | ||
| zap.String("chain_name", tunnels[i].TargetChainID), | ||
| zap.Uint64("tunnel_id", tunnels[i].ID), | ||
| ) | ||
| } | ||
|
|
||
| s.BandLatestTunnel = len(tunnels) |
| CheckingPacketInterval: checkingPacketInterval, | ||
| SyncTunnelsInterval: syncTunnelsInterval, | ||
| MaxCheckingPacketPenaltyDuration: maxCheckingPacketPenaltyDuration, | ||
| ExponentialFactor: exponentialFactor, | ||
| isErrorOnHolds: make([]bool, len(tunnelRelayers)), | ||
| isSyncTunnelsAllowed: isSyncTunnelsAllowed, | ||
| isErrorOnHolds: []bool{}, | ||
| penaltyTaskCh: make(chan Task, penaltyTaskChSize), | ||
| BandClient: bandClient, | ||
| ChainProviders: chainProviders, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #XXXX
Implementation details
SyncTunnelslogicPlease ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)