using sync functions of the SDK for overlapping flows #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrandSchtroumpf
requested changes
Jan 29, 2024
Deploying with
|
| Latest commit: |
45c5d0e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b3c67317.carbon-app-csq.pages.dev |
| Branch Preview URL: | https://sdk-sync-methods.carbon-app-csq.pages.dev |
|
handled as part of another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of the latest version of the SDK in which breaking change was introduced to calculate overlapping prices - namely not requiring the quote token address and not limiting prices to a 1 wei resolution.
Switched over the app to use sync functions instead of async - given that the app has the token decimals to provide.