Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart works with values below 1wei #1006

Merged
merged 14 commits into from
Feb 2, 2024
Merged

Chart works with values below 1wei #1006

merged 14 commits into from
Feb 2, 2024

Conversation

GrandSchtroumpf
Copy link
Collaborator

@GrandSchtroumpf GrandSchtroumpf commented Jan 26, 2024 •
edited
Loading

fix #988

  • update graph to support number below 1wei
  • update SDK version to have sync function & full price decimal
  • cleanup code after sync function
  • verify above/below market on every change
  • Remove unused utils

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 26, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 54a7e54
Status: ✅  Deploy successful!
Preview URL: https://3a88c238.carbon-app-csq.pages.dev
Branch Preview URL: https://issue--988.carbon-app-csq.pages.dev

View logs

@GrandSchtroumpf GrandSchtroumpf marked this pull request as ready for review January 30, 2024 13:41
zavelevsky
zavelevsky approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@zavelevsky zavelevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GrandSchtroumpf GrandSchtroumpf merged commit 9238e73 into main Feb 2, 2024
1 check passed
@GrandSchtroumpf GrandSchtroumpf deleted the issue-#988 branch February 2, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zavelevsky zavelevsky zavelevsky approved these changes

@ashachaf ashachaf ashachaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Overlapping] Chart not working well on a 1wei scale
3 participants
@GrandSchtroumpf @zavelevsky @ashachaf