Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove returning error message when observer-context is null #86

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Remove returning error message when observer-context is null #86

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0e6be3
Remove returning err msg when observer-context is null
NipunaMadhushan Jan 16, 2024
996b30c
Remove comments
NipunaMadhushan Jan 17, 2024
c5cf01b
Add a comment
NipunaMadhushan Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions native/src/main/java/io/ballerina/stdlib/observe/nativeimpl/OpenTracerBallerinaWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,10 @@ public Object addTag(Environment env, String tagKey, String tagValue, long spanI
if (spanId == -1) {
ObserverContext observer = ObserveUtils.getObserverContextOfCurrentFrame(env);
if (observer == null) {
return ErrorCreator.createError(
StringUtils.fromString(
("Span already finished. Can not add tag {" + tagKey + ":" + tagValue + "}")));
// This is a case where the user has not started the tracing.
// ObserverContext will be null if function is executed without entry point like main or resource
// function ex. initialising phase.
return null;
}
span = observer.getSpan();
} else {
Expand Down
Loading