Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional ports to Cloud.toml #796

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

xlight05
Copy link
Contributor

@xlight05 xlight05 commented May 31, 2024

Purpose

$Subject
Related : https://github.com/wso2-enterprise/internal-support-ballerina/issues/685
Users can use container.image.additionalPorts field to provide additional ports to be exposed which are not detected by c2c.
Sample -

[container.image]
repository="xlight05"
name="diff_port"
additional_ports = [9092]

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@xlight05 xlight05 force-pushed the additional-ports branch 4 times, most recently from c298f28 to e3e088c Compare June 1, 2024 00:39
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 88.37209% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (2201.9.x@a2d917f). Learn more about missing BASE report.

Files Patch % Lines
...n/java/io/ballerina/c2c/tasks/C2CAnalysisTask.java 86.36% 0 Missing and 3 partials ⚠️
...c/main/java/io/ballerina/c2c/utils/TomlHelper.java 84.61% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             2201.9.x     #796   +/-   ##
===========================================
  Coverage            ?   83.11%           
  Complexity          ?      398           
===========================================
  Files               ?       47           
  Lines               ?     2090           
  Branches            ?      259           
===========================================
  Hits                ?     1737           
  Misses              ?      232           
  Partials            ?      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xlight05 xlight05 merged commit b57e0f5 into ballerina-platform:2201.9.x Jun 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants