Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing a custom truststore with central calls #43621

Conversation

azinneera
Copy link
Contributor

@azinneera azinneera commented Nov 20, 2024

Purpose

Support passing a custom truststore with central calls

Approach

A custom truststore path can be set with the below environment variables:
BALLERINA_CA_BUNDLE
BALLERINA_CA_PASSWORD
BALLERINA_CA_CERT

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@azinneera azinneera force-pushed the prj_api_customTruststore branch from c7fd6e1 to 808f3dc Compare November 20, 2024 12:01
@azinneera azinneera force-pushed the prj_api_customTruststore branch from 808f3dc to b274bd2 Compare November 21, 2024 04:28
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 59.45946% with 15 lines in your changes missing coverage. Please review.

Please upload report for BASE (2201.11.0-stage@c4c87cb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ballerinalang/central/client/CentralAPIClient.java 59.45% 13 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             2201.11.0-stage   #43621   +/-   ##
==================================================
  Coverage                   ?   77.40%           
  Complexity                 ?    58583           
==================================================
  Files                      ?     3445           
  Lines                      ?   219080           
  Branches                   ?    28962           
==================================================
  Hits                       ?   169568           
  Misses                     ?    40093           
  Partials                   ?     9419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@azinneera azinneera force-pushed the prj_api_customTruststore branch from 6fa5e07 to 8b48602 Compare November 25, 2024 09:26
@azinneera azinneera changed the base branch from master to 2201.11.0-stage November 25, 2024 09:33
@azinneera azinneera added this to the 2201.11.0 milestone Nov 25, 2024
@azinneera azinneera dismissed sameerajayasoma’s stale review November 25, 2024 17:35

Addressed the review

@azinneera azinneera merged commit 03fa53f into ballerina-platform:2201.11.0-stage Nov 25, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants