Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad sad error occurred with incorrect central token #42152

Conversation

Thevakumar-Luheerathan
Copy link
Member

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #41785

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

ShammiL
ShammiL previously approved these changes Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (0823dc9) 0.00% compared to head (98bed87) 76.70%.
Report is 36 commits behind head on master.

Files Patch % Lines
...ballerinalang/central/client/CentralAPIClient.java 25.00% 12 Missing ⚠️
.../main/java/org/ballerinalang/docgen/Generator.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #42152       +/-   ##
=============================================
+ Coverage      0.00%   76.70%   +76.70%     
- Complexity        0    53052    +53052     
=============================================
  Files             9     2883     +2874     
  Lines            35   199976   +199941     
  Branches          0    26031    +26031     
=============================================
+ Hits              0   153389   +153389     
- Misses           35    38134    +38099     
- Partials          0     8453     +8453     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thevakumar-Luheerathan Thevakumar-Luheerathan merged commit b81de2d into ballerina-platform:master Feb 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error message in bal pack when the token is invalid
3 participants