-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change bal add
generated code to adhere to best practices
#42136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b9b7f2c.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #42136 +/- ##
=============================================
+ Coverage 0.00% 76.71% +76.71%
- Complexity 0 53064 +53064
=============================================
Files 9 2883 +2874
Lines 35 199980 +199945
Branches 0 26033 +26033
=============================================
+ Hits 0 153422 +153422
- Misses 35 38113 +38078
- Partials 0 8445 +8445 ☔ View full report in Codecov by Sentry. |
cli/ballerina-cli/src/main/resources/create_cmd_templates/lib/lib.bal
Outdated
Show resolved
Hide resolved
nipunayf
reviewed
Feb 12, 2024
cli/ballerina-cli/src/main/resources/create_cmd_templates/service/service.bal
Outdated
Show resolved
Hide resolved
Dilhasha
reviewed
Feb 15, 2024
cli/ballerina-cli/src/main/resources/create_cmd_templates/service/service.bal
Outdated
Show resolved
Hide resolved
Dilhasha
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #41775
Approach
Samples
Remarks
Check List