Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lifecycle plugin diagnostics being ignored during executable generation #42131

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

ShammiL
Copy link
Contributor

@ShammiL ShammiL commented Feb 8, 2024

Purpose

$Subject

Fixes #41915

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Dilhasha
Dilhasha previously approved these changes Feb 9, 2024
@ShammiL ShammiL dismissed stale reviews from Dilhasha and gayaldassanayake via 64157b2 February 13, 2024 09:24
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (0823dc9) 0.00% compared to head (f5263f5) 76.70%.
Report is 36 commits behind head on master.

Files Patch % Lines
.../java/io/ballerina/projects/JBallerinaBackend.java 62.50% 3 Missing ⚠️
...va/io/ballerina/cli/task/CreateExecutableTask.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #42131       +/-   ##
=============================================
+ Coverage      0.00%   76.70%   +76.70%     
- Complexity        0    53048    +53048     
=============================================
  Files             9     2883     +2874     
  Lines            35   199972   +199937     
  Branches          0    26030    +26030     
=============================================
+ Hits              0   153390   +153390     
- Misses           35    38131    +38096     
- Partials          0     8451     +8451     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShammiL ShammiL merged commit 45ab4cd into ballerina-platform:master Feb 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Diagnostics reported in CompilerLifecycleEventContext are ignored
4 participants