Set determine type for query and conditional expressions when the expected types are incompatible #42074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nipunayf
requested review from
mohanvive,
sameerajayasoma and
hasithaa
as code owners
nipunayf
added
the
Team/LanguageServer
KavinduZoysa
requested review from
KavinduZoysa,
LakshanWeerasinghe and
mindula
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #42074 +/- ##
=========================================
Coverage 76.68% 76.69%
- Complexity 53030 53036 +6
=========================================
Files 2883 2883
Lines 199951 199967 +16
Branches 26034 26035 +1
=========================================
+ Hits 153340 153357 +17
Misses 38146 38146
+ Partials 8465 8464 -1 ☔ View full report in Codecov by Sentry. |
KavinduZoysa
previously approved these changes
Jan 31, 2024
Comment on lines
+18
to
+20
| function testNestedElvisExpr1(string? nullableStr) { | ||
| return nullableStr ?: false; | ||
| } |
There was a problem hiding this comment.
This can be a arrow function
There was a problem hiding this comment.
These are test resources for the CAs. We are using this approach because it is more convenient to reproduce the line positions for the CA test cases.
Comment on lines
8
to
15
| type Student record { | ||
| int id; | ||
| string fname; | ||
| string lname; | ||
| int age; | ||
| float gpa; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Suggested change
| type Student record { | |
| int id; | |
| string fname; | |
| string lname; | |
| int age; | |
| float gpa; | |
| }; | |
| type Student record {| | |
| int id; | |
| string fname; | |
| string lname; | |
| int age; | |
| float gpa; | |
| |}; | |
Comment on lines
35
to
39
| function testQueryExprWithOnConflict() { | ||
| return table key(id) from var st in getStudents().toStream() | ||
| select <Person>{id: st.id, name: st.fname, age: st.age} | ||
| on conflict error("Conflicted Key", cKey = st.id); | ||
| } |
There was a problem hiding this comment.
These functions can be arrow functions
KavinduZoysa
approved these changes
Feb 2, 2024
KavinduZoysa
merged commit 6943c66
into
ballerina-platform:master
17 of 18 checks passed
nipunayf
added
Team/CompilerFE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The current implementation of the type checker does not determine the type for query and conditional expressions when the expected type is incompatible. Thus, the
typeOfAPI in the semantic model returns an compilation error type for the respective expressions.Fixes #42009
Fixes #41864
Approach
Silent type checking is used where applicable to determine the actual type for the respective expressions. Additionally, the FixReturnType code action is modified to consider one more ancestor to support conditional expressions.
Samples
Remarks
fix return typeCA, the current implementation only considers nested expressions up to two levels. Hence, the CA does not provide nested expressions deeper than 2 levels as it is not a priority and impacts the performance of the common use case.fix return typeCA for structural constructor expressions #42076Fix return typeCA does not support function expressions #42103Check List