Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix let expression usage inside query actions #42068

Merged

Conversation

LakshanWeerasinghe
Copy link
Contributor

Purpose

$subject

Fixes #40229

Approach

In the query desugar we were desugaring the expression of the let expression before desugaring the let variable declaration. Because of that there were unwanted statements added at the query desugar level resulted in compiler crash. Changing the desuaging order will fixed the issue.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 522 lines in your changes are missing coverage. Please review.

Comparison is base (04b5210) 76.68% compared to head (7ecb277) 76.67%.
Report is 787 commits behind head on master.

Files Patch % Lines
...rc/main/java/io/ballerina/cli/cmd/ToolCommand.java 0.00% 78 Missing ⚠️
...2/ballerinalang/compiler/bir/model/BIRVisitor.java 0.00% 70 Missing ⚠️
...java/io/ballerina/runtime/internal/ValueUtils.java 38.57% 42 Missing and 1 partial ⚠️
...ballerinalang/central/client/CentralAPIClient.java 25.53% 29 Missing and 6 partials ⚠️
...in/java/io/ballerina/projects/DependencyGraph.java 0.00% 24 Missing ⚠️
...o/ballerina/projects/internal/ManifestBuilder.java 76.92% 16 Missing and 8 partials ⚠️
...rc/main/java/io/ballerina/cli/cmd/PushCommand.java 60.00% 14 Missing and 2 partials ⚠️
...lerina/cli/task/RunBallerinaPreBuildToolsTask.java 65.95% 10 Missing and 6 partials ⚠️
...rinalang/compiler/bir/emit/InstructionEmitter.java 0.00% 15 Missing ⚠️
...a/io/ballerina/cli/launcher/util/BalToolsUtil.java 0.00% 14 Missing ⚠️
... and 44 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #42068      +/-   ##
============================================
- Coverage     76.68%   76.67%   -0.01%     
- Complexity    53019    53020       +1     
============================================
  Files          2883     2883              
  Lines        199924   199924              
  Branches      26024    26024              
============================================
- Hits         153305   153301       -4     
- Misses        38157    38160       +3     
- Partials       8462     8463       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KavinduZoysa KavinduZoysa merged commit 989a733 into ballerina-platform:master Feb 8, 2024
16 of 18 checks passed
@LakshanWeerasinghe LakshanWeerasinghe added this to the 2201.9.0 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Crash in let-expr inside do-clause
3 participants