Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.8.x] Fix CustomToolClassLoader linkage issue #42056

Conversation

gayaldassanayake
Copy link
Contributor

@gayaldassanayake gayaldassanayake commented Jan 29, 2024

Purpose

8.x PR of #42055

Fixes #41957

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@gayaldassanayake gayaldassanayake changed the title Fix CustomToolClassLoader linkage issue [2201.8.x] Fix CustomToolClassLoader linkage issue Jan 29, 2024
}
if (resolve) {
resolveClass(loadedClass);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be improved as resolveClass(Objects.requireNonNull(loadedClass));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with ecdf19e

@gayaldassanayake
Copy link
Contributor Author

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (3563e7b) 76.36% compared to head (ecdf19e) 76.35%.
Report is 6 commits behind head on 2201.8.x.

Files Patch % Lines
.../ballerina/cli/launcher/CustomToolClassLoader.java 0.00% 32 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             2201.8.x   #42056      +/-   ##
==============================================
- Coverage       76.36%   76.35%   -0.01%     
- Complexity      52568    52570       +2     
==============================================
  Files            2880     2880              
  Lines          198795   198823      +28     
  Branches        25829    25839      +10     
==============================================
+ Hits           151809   151819      +10     
- Misses          38631    38648      +17     
- Partials         8355     8356       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gayaldassanayake gayaldassanayake merged commit 61e02f6 into ballerina-platform:2201.8.x Jan 30, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants