Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rename position in Extract to local variable and Extract to constant code actions #42033

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

mindula
Copy link
Contributor

@mindula mindula commented Jan 23, 2024

Purpose

$subject

Fixes #40525

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link
Contributor

@LakshanWeerasinghe LakshanWeerasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a test to extract to variable code action as well. And also lets add a test for extracting a literal value at the function body as well.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f65e799) 76.64% compared to head (4ba5b8d) 76.67%.
Report is 14 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #42033      +/-   ##
============================================
+ Coverage     76.64%   76.67%   +0.03%     
+ Complexity    53018    53017       -1     
============================================
  Files          2883     2883              
  Lines        199917   199920       +3     
  Branches      26021    26022       +1     
============================================
+ Hits         153232   153296      +64     
+ Misses        38234    38161      -73     
- Partials       8451     8463      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mindula mindula added the Team/LanguageServer Language Server Implementation related issues. #Compiler label Jan 24, 2024
@KavinduZoysa KavinduZoysa merged commit a7a0e92 into ballerina-platform:master Jan 31, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/LanguageServer Language Server Implementation related issues. #Compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing rename popup in extract to local variable code action
3 participants