Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE from daemon strand for record value creation #42030

Merged
merged 9 commits into from
Feb 1, 2024

Conversation

HindujaB
Copy link
Contributor

@HindujaB HindujaB commented Jan 22, 2024

Purpose

$Subject
Fixes #42027

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 485 lines in your changes are missing coverage. Please review.

Comparison is base (04b5210) 76.68% compared to head (1662512) 76.70%.
Report is 783 commits behind head on master.

Files Patch % Lines
...rc/main/java/io/ballerina/cli/cmd/ToolCommand.java 0.00% 78 Missing ⚠️
...2/ballerinalang/compiler/bir/model/BIRVisitor.java 0.00% 70 Missing ⚠️
...ballerinalang/central/client/CentralAPIClient.java 25.53% 29 Missing and 6 partials ⚠️
...in/java/io/ballerina/projects/DependencyGraph.java 0.00% 24 Missing ⚠️
...o/ballerina/projects/internal/ManifestBuilder.java 76.92% 16 Missing and 8 partials ⚠️
...rc/main/java/io/ballerina/cli/cmd/PushCommand.java 60.00% 14 Missing and 2 partials ⚠️
...lerina/cli/task/RunBallerinaPreBuildToolsTask.java 65.95% 10 Missing and 6 partials ⚠️
...rinalang/compiler/bir/emit/InstructionEmitter.java 0.00% 15 Missing ⚠️
...a/io/ballerina/cli/launcher/util/BalToolsUtil.java 0.00% 14 Missing ⚠️
...n/java/org/ballerinalang/central/client/Utils.java 60.00% 13 Missing and 1 partial ⚠️
... and 43 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #42030      +/-   ##
============================================
+ Coverage     76.68%   76.70%   +0.02%     
- Complexity    53019    53034      +15     
============================================
  Files          2883     2883              
  Lines        199924   199923       -1     
  Branches      26024    26024              
============================================
+ Hits         153305   153345      +40     
+ Misses        38157    38116      -41     
  Partials       8462     8462              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HindujaB HindujaB changed the title [WIP] Fix NPE from daemon strand Fix NPE from daemon strand Jan 23, 2024
@HindujaB HindujaB changed the title Fix NPE from daemon strand Fix NPE from daemon strand for record value creation Jan 23, 2024
Nadeeshan96
Nadeeshan96 previously approved these changes Jan 29, 2024
Copy link
Contributor

@Nadeeshan96 Nadeeshan96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Nadeeshan96 Nadeeshan96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@warunalakshitha warunalakshitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha warunalakshitha merged commit fa09ebb into ballerina-platform:master Feb 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Simple POST request from a cURL client fails with NPE for a Ballerina service ran using lang master
4 participants