-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error on accessing a constant list defined in a module #41942
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #41942 +/- ##
=========================================
Coverage 76.67% 76.68%
- Complexity 53094 53099 +5
=========================================
Files 2884 2884
Lines 200207 200209 +2
Branches 26076 26076
=========================================
+ Hits 153516 153526 +10
+ Misses 38260 38256 -4
+ Partials 8431 8427 -4 ☔ View full report in Codecov by Sentry. |
...ina-unit-test/src/test/java/org/ballerinalang/test/bala/constant/ListConstantInBalaTest.java
Show resolved
Hide resolved
...rina-unit-test/src/test/resources/test-src/bala/test_projects/test_project/list-constant.bal
Outdated
Show resolved
Hide resolved
...ng/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/ConstantTypeChecker.java
Outdated
Show resolved
Hide resolved
In the current implementation, symbol accessibility is verified using the type symbol(( Line 3538 in 788e142
|
...rina-unit-test/src/test/resources/test-src/bala/test_bala/constant/list-literal-constant.bal
Outdated
Show resolved
Hide resolved
...ina-unit-test/src/test/resources/test-src/bala/test_bala/constant/list_constant_negative.bal
Outdated
Show resolved
Hide resolved
...ina-unit-test/src/test/java/org/ballerinalang/test/bala/constant/ListConstantInBalaTest.java
Outdated
Show resolved
Hide resolved
...-test/src/test/java/org/ballerinalang/test/bala/constant/ListConstantInBalaNegativeTest.java
Outdated
Show resolved
Hide resolved
...-test/src/test/java/org/ballerinalang/test/bala/constant/ListConstantInBalaNegativeTest.java
Outdated
Show resolved
Hide resolved
...rina-unit-test/src/test/resources/test-src/bala/test_bala/constant/list-literal-constant.bal
Outdated
Show resolved
Hide resolved
...ng/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/ConstantTypeChecker.java
Outdated
Show resolved
Hide resolved
...ina-unit-test/src/test/resources/test-src/bala/test_bala/constant/list_constant_negative.bal
Outdated
Show resolved
Hide resolved
...rina-unit-test/src/test/resources/test-src/bala/test_projects/test_project/list_constant.bal
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...ng/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/ConstantTypeChecker.java
Outdated
Show resolved
Hide resolved
71061b3
to
ef578da
Compare
...ina-unit-test/src/test/resources/test-src/bala/test_bala/constant/list_constant_negative.bal
Outdated
Show resolved
Hide resolved
...ng/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/ConstantTypeChecker.java
Outdated
Show resolved
Hide resolved
...-test/src/test/java/org/ballerinalang/test/bala/constant/ListConstantInBalaNegativeTest.java
Outdated
Show resolved
Hide resolved
...ina-unit-test/src/test/resources/test-src/bala/test_bala/constant/list_constant_negative.bal
Outdated
Show resolved
Hide resolved
c20e6e1
to
a6e5afa
Compare
Purpose
Fixes #41901
Samples
Remarks
Check List