Add name for readonly records in config schema generation #41914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dilhasha
requested review from
hevayo,
sameerajayasoma and
hasithaa
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #41914 +/- ##
============================================
- Coverage 76.69% 76.69% -0.01%
- Complexity 52904 52976 +72
============================================
Files 2881 2883 +2
Lines 199397 199727 +330
Branches 25929 25980 +51
============================================
+ Hits 152932 153185 +253
- Misses 38016 38078 +62
- Partials 8449 8464 +15 ☔ View full report in Codecov by Sentry. |
MaryamZi
reviewed
Dec 21, 2023
.../ballerina-lang/src/main/java/io/ballerina/projects/internal/configschema/TypeConverter.java
Outdated
Show resolved
Hide resolved
.../ballerina-lang/src/main/java/io/ballerina/projects/internal/configschema/TypeConverter.java
Outdated
Show resolved
Hide resolved
| typeNode.addProperty("name", bType.toString().trim()); | ||
| // The tsymbol name is empty for anon intersection type created due to inferred readonly | ||
| if (!intersectionType.tsymbol.name.value.isEmpty()) { | ||
| typeNode.addProperty("name", intersectionType.tsymbol.toString().trim()); |
There was a problem hiding this comment.
Shouldn't this be tsymbol.name.value?
There was a problem hiding this comment.
tsymbol.name.value doesn't return the fully qualified name.
MaryamZi
reviewed
Jan 4, 2024
.../ballerina-lang/src/main/java/io/ballerina/projects/internal/configschema/TypeConverter.java
Outdated
Show resolved
Hide resolved
.../ballerina-lang/src/main/java/io/ballerina/projects/internal/configschema/TypeConverter.java
Outdated
Show resolved
Hide resolved
azinneera
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix failure when Config Generation fails to add the name of Readonly Records to the Config Schema.
Fixes #41906
Approach
Samples
Remarks
Check List