Make function rest parameters final #41844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LakshanWeerasinghe
requested review from
sameerajayasoma and
hasithaa
as code owners
LakshanWeerasinghe
added
Team/CompilerFE
MaryamZi
reviewed
Dec 8, 2023
| @@ -44,3 +44,7 @@ listener test:MockListener ml = new (8080); | |||
| public function testChangingListenerVariableAfterDefining() { | |||
| ml = new test:MockListener(8081); | |||
| } | |||
|
|
|||
| function restFinal(string p1, string... p2) { | |||
There was a problem hiding this comment.
Rename the function to say testXxx reflecting what's being tested.
There was a problem hiding this comment.
Updated in 85eab29.
...na-unit-test/src/test/resources/test-src/types/finaltypes/test_implicitly_final_negative.bal
Show resolved
Hide resolved
...llerina-unit-test/src/test/java/org/ballerinalang/test/types/finaltypes/FinalAccessTest.java
Outdated
Show resolved
Hide resolved
...llerina-unit-test/src/test/java/org/ballerinalang/test/types/finaltypes/FinalAccessTest.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #41844 +/- ##
============================================
- Coverage 76.67% 76.67% -0.01%
- Complexity 53002 53013 +11
============================================
Files 2883 2883
Lines 199881 199918 +37
Branches 26011 26021 +10
============================================
+ Hits 153264 153286 +22
- Misses 38157 38168 +11
- Partials 8460 8464 +4 ☔ View full report in Codecov by Sentry. |
...-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SemanticAnalyzer.java
Outdated
Show resolved
Hide resolved
MaryamZi
reviewed
Dec 14, 2023
...-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SemanticAnalyzer.java
Outdated
Show resolved
Hide resolved
...na-unit-test/src/test/resources/test-src/types/finaltypes/test_implicitly_final_negative.bal
Outdated
Show resolved
Hide resolved
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
chiranSachintha
previously approved these changes
Jan 9, 2024
LakshanWeerasinghe
force-pushed
the
fix-#41833
branch
from
35632b8 to
bf890dc
Compare
KavinduZoysa
approved these changes
Jan 21, 2024
MaryamZi
approved these changes
Jan 23, 2024
KavinduZoysa
merged commit 5bf5d9f
into
ballerina-platform:master
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Fixes #41833
Approach
Samples
Remarks
Check List