Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profiler crashes in windows #41823

Merged

Conversation

gabilang
Copy link
Contributor

@gabilang gabilang commented Dec 4, 2023

Purpose

$title

Fixes #41576
Fixes #41578
Fixes #41577

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@gabilang gabilang added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3096527) 76.70% compared to head (2062c7d) 76.70%.
Report is 4 commits behind head on master.

Files Patch % Lines
...in/java/io/ballerina/cli/task/RunProfilerTask.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #41823   +/-   ##
=========================================
  Coverage     76.70%   76.70%           
- Complexity    52923    52924    +1     
=========================================
  Files          2881     2881           
  Lines        199440   199441    +1     
  Branches      25936    25936           
=========================================
+ Hits         152979   152983    +4     
+ Misses        38017    38014    -3     
  Partials       8444     8444           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gabilang gabilang marked this pull request as ready for review December 14, 2023 03:37
Copy link
Contributor

@warunalakshitha warunalakshitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha warunalakshitha merged commit b2c2c42 into ballerina-platform:master Jan 3, 2024
16 of 17 checks passed
@gabilang gabilang deleted the fix-profiler-windows branch January 22, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
2 participants