Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.7.x] Fix OOM error when parsing XML CData #41745

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

Nadeeshan96
Copy link
Contributor

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

$title
Duplicate PR #41673
Fixes #41671

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@Nadeeshan96 Nadeeshan96 added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Nov 21, 2023
@Nadeeshan96 Nadeeshan96 requested a review from gabilang November 21, 2023 12:49
Copy link
Contributor

@HindujaB HindujaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05141ec) 76.37% compared to head (593560e) 76.37%.
Report is 1 commits behind head on 2201.7.x.

Additional details and impacted files
@@             Coverage Diff             @@
##             2201.7.x   #41745   +/-   ##
===========================================
  Coverage       76.37%   76.37%           
  Complexity      55274    55274           
===========================================
  Files            3387     3387           
  Lines          208632   208636    +4     
  Branches        26976    26976           
===========================================
+ Hits           159340   159348    +8     
+ Misses          40580    40575    -5     
- Partials         8712     8713    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nadeeshan96 Nadeeshan96 merged commit b0666ad into ballerina-platform:2201.7.x Nov 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants