Replace duplicate symbol in owner #41737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #41737 +/- ##
=========================================
Coverage 76.71% 76.71%
- Complexity 52668 52671 +3
=========================================
Files 2880 2880
Lines 198580 198593 +13
Branches 25801 25805 +4
=========================================
+ Hits 152340 152350 +10
- Misses 37805 37806 +1
- Partials 8435 8437 +2 ☔ View full report in Codecov by Sentry. |
hasithaa
reviewed
Nov 22, 2023
| if (!Symbols.isFlagOn(invokableSymbol.flags, Flags.ATTACHED)) { | ||
| return dupFuncSymbol; | ||
| } | ||
| List<BAttachedFunction> attachedFuncs = ((BStructureTypeSymbol) invokableSymbol.owner).attachedFuncs; |
There was a problem hiding this comment.
I guess this modifies the BIR. maybe we should add a BIR test case to verify this.
hasithaa
approved these changes
Nov 22, 2023
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
|
Closed PR due to inactivity for more than 18 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wso2/ballerina-vscode#503