Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diagnostic errors for package name and org in Ballerina.toml file. #41732

Merged
merged 9 commits into from
Dec 7, 2023

Conversation

ShammiL
Copy link
Contributor

@ShammiL ShammiL commented Nov 20, 2023

Purpose

$Subject

Fixes #41599

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8bc2d15) 76.71% compared to head (54053e8) 76.71%.
Report is 458 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #41732      +/-   ##
============================================
- Coverage     76.71%   76.71%   -0.01%     
+ Complexity    52668    52667       -1     
============================================
  Files          2880     2880              
  Lines        198580   198584       +4     
  Branches      25801    25802       +1     
============================================
- Hits         152340   152335       -5     
- Misses        37805    37813       +8     
- Partials       8435     8436       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 6, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Dec 6, 2023
@azinneera azinneera removed the Stale label Dec 7, 2023
@azinneera azinneera merged commit a2d992e into ballerina-platform:master Dec 7, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Empty package 'org' and 'name' in Ballerina.toml gives false error diagnostics
3 participants