Fix invalid behavior in TableIterator with hash-collided keys
#41722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nipunayf
requested review from
warunalakshitha,
sameerajayasoma and
hasithaa
as code owners
nipunayf
requested review from
KavinduZoysa and
gimantha
and removed request for
hasithaa,
sameerajayasoma and
warunalakshitha
nipunayf
changed the title
nipunayf
changed the title
TableIterator with hash-collided keys
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #41722 +/- ##
============================================
+ Coverage 76.67% 76.70% +0.02%
+ Complexity 52929 52924 -5
============================================
Files 2881 2881
Lines 199440 199434 -6
Branches 25936 25939 +3
============================================
+ Hits 152927 152976 +49
+ Misses 38084 38012 -72
- Partials 8429 8446 +17 ☔ View full report in Codecov by Sentry. |
nipunayf
added
the
Team/jBallerina
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
nipunayf
force-pushed
the
fix-hash-collisions
branch
from
cf9dada to
bb13478
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The current implementation of the TableIterator does not consider hash collisions, as it treats its map implementations to have a one-to-one mapping. Hence, when there are hash-collided keys, the behavior produces invalid error messages.
Fixes #41717
Fixes #41719
Fixes #41721
Fixes #41819
Approach
The PR modifies the map implementation of the
TableValueclass to handle hash collisions in the iterator behavior.Check List