Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace extern with external in interop error messages #41632

Closed

Conversation

gabilang
Copy link
Contributor

@gabilang gabilang commented Nov 2, 2023

Purpose

$title

Fixes #41620

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@gabilang gabilang added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a16695) 76.67% compared to head (94e1a1a) 76.68%.
Report is 100 commits behind head on master.

❗ Current head 94e1a1a differs from pull request most recent head 1af70be. Consider uploading reports for the commit 1af70be to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #41632      +/-   ##
============================================
+ Coverage     76.67%   76.68%   +0.01%     
- Complexity    52669    52676       +7     
============================================
  Files          2881     2881              
  Lines        198686   198686              
  Branches      25822    25822              
============================================
+ Hits         152350   152371      +21     
+ Misses        37896    37880      -16     
+ Partials       8440     8435       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: lochana-chathura <39232462+lochana-chathura@users.noreply.github.com>
@gabilang
Copy link
Contributor Author

Closing this PR since the old-style external function wrapper related changes are removed with the PR #41658

@gabilang gabilang closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Typo in error message when an external function is declared with no java class specified
2 participants