Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StackOverflow with equals check of maps with cyclic references #41586

Merged

Conversation

gabilang
Copy link
Contributor

@gabilang gabilang commented Oct 27, 2023

Purpose

$title

Fixes #33929

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: Patch coverage is 83.80282% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 76.71%. Comparing base (cc94e6e) to head (f5ab4a1).
Report is 302 commits behind head on master.

Files Patch % Lines
...ava/io/ballerina/runtime/internal/TypeChecker.java 78.26% 0 Missing and 5 partials ⚠️
.../ballerina/runtime/internal/values/ErrorValue.java 0.00% 4 Missing ⚠️
...lerina/runtime/internal/values/TableValueImpl.java 88.00% 1 Missing and 2 partials ⚠️
...ballerina/runtime/internal/values/XmlSequence.java 75.00% 0 Missing and 3 partials ⚠️
...o/ballerina/runtime/internal/values/ValuePair.java 85.71% 1 Missing and 1 partial ⚠️
.../io/ballerina/runtime/internal/values/XmlItem.java 80.00% 0 Missing and 2 partials ⚠️
.../io/ballerina/runtime/internal/values/XmlText.java 50.00% 0 Missing and 2 partials ⚠️
...allerina/runtime/internal/values/MapValueImpl.java 93.33% 0 Missing and 1 partial ⚠️
...io/ballerina/runtime/internal/values/RefValue.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #41586   +/-   ##
=========================================
  Coverage     76.71%   76.71%           
- Complexity    53071    53072    +1     
=========================================
  Files          2884     2886    +2     
  Lines        200023   200013   -10     
  Branches      26041    26036    -5     
=========================================
- Hits         153445   153443    -2     
- Misses        38134    38136    +2     
+ Partials       8444     8434   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gabilang gabilang added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Oct 30, 2023
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Nov 14, 2023
@gabilang gabilang removed the Stale label Nov 16, 2023
@gabilang gabilang marked this pull request as ready for review November 29, 2023 11:28
HindujaB
HindujaB previously approved these changes Jan 18, 2024
Copy link
Contributor

@HindujaB HindujaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Nadeeshan96 Nadeeshan96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Feb 2, 2024

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Feb 2, 2024
@gabilang gabilang removed the Stale label Feb 3, 2024
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Feb 18, 2024
@gabilang gabilang removed the Stale label Feb 19, 2024
Copy link

github-actions bot commented Mar 9, 2024

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Mar 9, 2024
@gabilang gabilang removed the Stale label Mar 11, 2024
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Mar 26, 2024
@gabilang gabilang removed the Stale label Mar 27, 2024
Copy link
Contributor

@warunalakshitha warunalakshitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha warunalakshitha merged commit 9dd67e9 into ballerina-platform:master Mar 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make == deal with cycles
4 participants