Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.8.x] Remove unncessary CapturedClosureEnvs in Lambda functions #41400

Merged
merged 5 commits into from
Oct 5, 2023

Conversation

gimantha
Copy link
Contributor

@gimantha gimantha commented Sep 18, 2023

Fixes #41448

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@gimantha gimantha changed the title 2201.8.x Remove unncessary CapturedClosureEnvs in Lambda functions [2201.8.x] Remove unncessary CapturedClosureEnvs in Lambda functions Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (31661a2) 76.33% compared to head (102f599) 76.36%.
Report is 51 commits behind head on 2201.8.x.

❗ Current head 102f599 differs from pull request most recent head ddbe706. Consider uploading reports for the commit ddbe706 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             2201.8.x   #41400      +/-   ##
==============================================
+ Coverage       76.33%   76.36%   +0.02%     
- Complexity      52462    52496      +34     
==============================================
  Files            2881     2881              
  Lines          198393   198414      +21     
  Branches        25783    25783              
==============================================
+ Hits           151439   151511      +72     
+ Misses          38604    38557      -47     
+ Partials         8350     8346       -4     
Files Coverage Δ
...lerina/runtime/api/constants/RuntimeConstants.java 100.00% <ø> (ø)
...java/io/ballerina/runtime/internal/JsonParser.java 77.89% <100.00%> (ø)
...in/java/io/ballerina/projects/DocumentContext.java 98.55% <100.00%> (+0.08%) ⬆️
...main/java/io/ballerina/projects/ModuleContext.java 88.17% <100.00%> (+0.08%) ⬆️
...lerinalang/compiler/bir/codegen/CodeGenerator.java 65.11% <100.00%> (ø)
...lerinalang/compiler/bir/codegen/JvmPackageGen.java 89.16% <100.00%> (ø)
...allerinalang/compiler/bir/codegen/JvmValueGen.java 93.10% <100.00%> (ø)
...lang/compiler/bir/codegen/ShutDownListenerGen.java 100.00% <100.00%> (ø)
...ompiler/bir/codegen/methodgen/ConfigMethodGen.java 97.84% <100.00%> (ø)
.../compiler/bir/codegen/methodgen/FrameClassGen.java 94.87% <100.00%> (ø)
... and 24 more

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chiranSachintha
Copy link
Member

We don't need to clone the env here(

) as well

@udda1996 udda1996 merged commit 775a621 into ballerina-platform:2201.8.x Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants