Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements/ bug fixes for bal tool feature #40457

Merged

Conversation

gayaldassanayake
Copy link
Contributor

@gayaldassanayake gayaldassanayake commented May 18, 2023

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Related to #40264

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@gayaldassanayake gayaldassanayake marked this pull request as ready for review May 18, 2023 13:37
azinneera
azinneera previously approved these changes May 18, 2023
@azinneera azinneera added this to the 2201.6.0 milestone May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 11.11% and project coverage change: -0.03 ⚠️

Comparison is base (e6c7bdc) 76.96% compared to head (b7aace6) 76.93%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40457      +/-   ##
============================================
- Coverage     76.96%   76.93%   -0.03%     
- Complexity    54413    54444      +31     
============================================
  Files          3354     3362       +8     
  Lines        202759   202962     +203     
  Branches      26060    26057       -3     
============================================
+ Hits         156044   156153     +109     
- Misses        38252    38341      +89     
- Partials       8463     8468       +5     
Impacted Files Coverage Δ
.../src/main/java/io/ballerina/cli/cmd/Constants.java 0.00% <ø> (ø)
.../java/io/ballerina/cli/launcher/LauncherUtils.java 11.53% <ø> (+4.64%) ⬆️
.../src/main/java/io/ballerina/cli/launcher/Main.java 30.62% <0.00%> (+1.10%) ⬆️
...ballerinalang/central/client/CentralAPIClient.java 36.80% <ø> (ø)
.../main/java/io/ballerina/projects/BalToolsToml.java 0.00% <0.00%> (ø)
...rc/main/java/io/ballerina/cli/cmd/ToolCommand.java 4.49% <100.00%> (ø)

... and 93 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gayaldassanayake gayaldassanayake merged commit a67704c into ballerina-platform:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants