Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Record default values support from runtime #39997

Closed
wants to merge 41 commits into from
Closed

[WIP] Record default values support from runtime #39997

wants to merge 41 commits into from

Conversation

HindujaB
Copy link
Contributor

Purpose

$subject

Fixes #37351

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

CheckList

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@chiranSachintha
Create closures for default values of record fields
b091f8e
@chiranSachintha
Updates fields of record literals
8239d79
@chiranSachintha
Refactor closure symbol mark logic
a1edca9
@chiranSachintha
Add flag to record fields withs default values
77f35a8
@chiranSachintha
Remove initFunction from record type node
d55e2e2
@chiranSachintha
Remove initializerFunc from record type symbol
830edc6
@chiranSachintha
Introduce default values to record type symbol
a75558f
@chiranSachintha
Update instantiate record values logic
98c8d6b
@chiranSachintha
Remove initializer from record type
1b7ee69
@chiranSachintha
Remove enclMapSymbols from BLangStructLiteral
8325e40
@chiranSachintha
Merge branch 'master' of https://github.com/ballerina-platform/baller…
c7cdb26 
…ina-lang into closures-for-record-default-values

� Conflicts:
�	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/BIRPackageSymbolEnter.java
�	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmDesugarPhase.java
�	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
�	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SemanticAnalyzer.java
�	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SymbolResolver.java
@chiranSachintha
Resolve conflicts
5922082
@chiranSachintha
Add default values info in the BIR
5eaa9f4
@chiranSachintha
Updates fields of record literals
bc27195
@chiranSachintha
Add default values to ksy file
9c69ed9
@chiranSachintha
Merge branch 'master' of https://github.com/ballerina-platform/baller…
22127cb 
…ina-lang into closures-for-record-default-values

� Conflicts:
�	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
�	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SemanticAnalyzer.java
�	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/util/ImmutableTypeCloner.java
�	tests/jballerina-debugger-integration-test/src/test/java/org/ballerinalang/debugger/test/adapter/variables/VariableVisibilityTest.java
�	tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/javainterop/DependentlyTypedFunctionsTest.java
@chiranSachintha
Merge branch 'master' of https://github.com/ballerina-platform/baller…
555e0a0 
…ina-lang into closures-for-record-default-values

� Conflicts:
�	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
�	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java
�	misc/debug-adapter/modules/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/evaluation/engine/action/RemoteMethodCallActionEvaluator.java
�	misc/debug-adapter/modules/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/utils/PackageUtils.java
@chiranSachintha
Merge branch 'closure-changes-for-function-defult-values' of https://…
bb22312 
…github.com/ballerina-platform/ballerina-lang into closures-for-record-default-values

� Conflicts:
�	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
�	tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/javainterop/DependentlyTypedFunctionsTest.java
@chiranSachintha
Remove duplicate visit function
f042529
@chiranSachintha
Add tests for record type
7b44339
@chiranSachintha
Enable builds on the closure branch
6ab8659
@chiranSachintha
Merge branch 'closure-changes-for-function-defult-values' of https://…
f34be4e 
…github.com/ballerina-platform/ballerina-lang into closures-for-record-default-values
@chiranSachintha
Set closures from the mutable type
ad672c7
@chiranSachintha
Merge branch 'master' of https://github.com/ballerina-platform/baller…
3a80a18 
…ina-lang into closures-for-record-default-values

� Conflicts:
�	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/split/creators/JvmRecordCreatorGen.java
@chiranSachintha
Resolve conflicts
6fe9727
@chiranSachintha
Rename ParameterDesugar to GenerateClosuresForDefaultValues
5868535
@chiranSachintha
Merge branch 'master' of https://github.com/ballerina-platform/baller…
ad68c3f 
…ina-lang into closures-for-record-default-values

� Conflicts:
�	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/tree/types/BLangObjectTypeNode.java
@chiranSachintha
fix review suggestions
7c5487b
@chiranSachintha
Merge branch 'master' of https://github.com/ballerina-platform/baller…
4ba8e40 
…ina-lang into closures-for-record-default-values

� Conflicts:
�	.github/workflows/pull_request_windows_build.yml
@chiranSachintha
fix review suggestions
bef24be
chiranSachintha and others added 10 commits November 11, 2022 14:45
@chiranSachintha
Allow intersection of readonly and record type with default values
5850bdf
@chiranSachintha
Add unit tests for intersection of readonly and record type with defa…
d7bcb23 
…ult values
@chiranSachintha
Merge branch 'master' of https://github.com/ballerina-platform/baller…
dbacbeb 
…ina-lang into closures-for-record-default-values

# Conflicts:
#	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/BIRPackageSymbolEnter.java
#	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/BIRGen.java
#	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/ClosureGenerator.java
#	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
#	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/model/symbols/BObjectTypeSymbol.java
#	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/model/symbols/BRecordTypeSymbol.java
@chiranSachintha
Resolve conflicts
4dcab88
@chiranSachintha
Rewrite expressions of fields in class definitions
c798f0c
@chiranSachintha
Merge branch 'master' of https://github.com/ballerina-platform/baller…
bc3708d 
…ina-lang into closures-for-record-default-values

# Conflicts:
#	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmValueGen.java
#	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/split/creators/JvmRecordCreatorGen.java
@chiranSachintha
Reorder import statements
8491f61
@chiranSachintha
Rewrite type node of test expression
0cb664b
@HindujaB
Modify runtime record creation
b5c4f63
@HindujaB
Add zero value method
87d3068
@HindujaB HindujaB force-pushed the record-default-values branch from 6985146 to 9c71230 Compare March 27, 2023 13:35
@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Apr 11, 2023
@HindujaB HindujaB removed the Stale label Apr 12, 2023
@HindujaB HindujaB marked this pull request as draft April 26, 2023 08:09
@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label May 11, 2023
@HindujaB HindujaB removed the Stale label May 14, 2023
@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label May 29, 2023
@HindujaB
Copy link
Contributor Author

Closing as the fix approach is changed to support spec.

@HindujaB HindujaB closed this May 31, 2023
@HindujaB
Copy link
Contributor Author

The correct change has been added with PR #40579. Hence, removing the stale label.

@HindujaB HindujaB removed the Stale label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warunalakshitha warunalakshitha Awaiting requested review from warunalakshitha warunalakshitha is a code owner

@sameerajayasoma sameerajayasoma Awaiting requested review from sameerajayasoma sameerajayasoma is a code owner

@hasithaa hasithaa Awaiting requested review from hasithaa hasithaa is a code owner

@gimantha gimantha Awaiting requested review from gimantha gimantha will be requested when the pull request is marked ready for review gimantha is a code owner

@MaryamZi MaryamZi Awaiting requested review from MaryamZi MaryamZi will be requested when the pull request is marked ready for review MaryamZi is a code owner

@KavinduZoysa KavinduZoysa Awaiting requested review from KavinduZoysa KavinduZoysa will be requested when the pull request is marked ready for review KavinduZoysa is a code owner

@azinneera azinneera Awaiting requested review from azinneera azinneera will be requested when the pull request is marked ready for review azinneera is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor record init with default values change
2 participants
@HindujaB @chiranSachintha