Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.3.x] Update visible endpoint generation to identify client object files with annotations #39502

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

kanushka
Copy link
Contributor

@kanushka kanushka commented Feb 5, 2023

Purpose

Update visible endpoint generation to identify client object files with annotations.

Fixes #39657

Approach

Semantic API doesn't send CLIENT qualifier for client object node with annotations. This PR will skip annotation from the node and request Semantic TypeSymbol just only for the client object.

service /abc on new http:Listener(9090) {

    @display {
        label: "InternalClientService",
    }
    InternalClient inEp3;

    function init() returns error? {
        self.inEp3 = check new InternalClient("http://example.com/internal/1");
    }

    resource function get repos(string orgName, int max = 5) returns string|error? {

    }

}

In the above example @display { label: "InternalClientService", } InternalClient inEp3 node won't get the CLIENT qualifier. But just creating a new node with InternalClient inEp3 will send the CLIENT qualifier.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@kanushka kanushka requested a review from hevayo as a code owner February 5, 2023 15:59
@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Base: 76.30% // Head: 76.30% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (594b5e9) compared to base (f96e936).
Patch coverage: 91.42% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             2201.3.x   #39502   +/-   ##
===========================================
  Coverage       76.30%   76.30%           
- Complexity      53139    53175   +36     
===========================================
  Files            3383     3384    +1     
  Lines          199847   199943   +96     
  Branches        26024    26067   +43     
===========================================
+ Hits           152487   152563   +76     
- Misses          38635    38650   +15     
- Partials         8725     8730    +5     
Impacted Files Coverage Δ
...lerinalang/diagramutil/SyntaxTreeMapGenerator.java 88.32% <80.00%> (-0.14%) ⬇️
...nalang/testerina/core/MockAnnotationProcessor.java 85.79% <93.33%> (+8.87%) ⬆️
...rs/createvar/CreateVariableWithTypeCodeAction.java 77.97% <0.00%> (-9.33%) ⬇️
...nalang/langserver/codeaction/CodeActionRouter.java 82.14% <0.00%> (-7.15%) ⬇️
...runtime/internal/scheduling/WorkerDataChannel.java 88.81% <0.00%> (-3.11%) ⬇️
...a/org/ballerinalang/langserver/LSClientLogger.java 56.16% <0.00%> (-1.37%) ⬇️
...lerinalang/debugadapter/JBallerinaDebugServer.java 71.97% <0.00%> (-1.29%) ⬇️
.../ballerina/runtime/internal/scheduling/Strand.java 79.67% <0.00%> (-0.82%) ⬇️
...g/diagramutil/connector/models/connector/Type.java 49.73% <0.00%> (-0.80%) ⬇️
...oviders/context/InvocationNodeContextProvider.java 83.95% <0.00%> (-0.78%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kanushka kanushka requested a review from CharukaK February 6, 2023 04:45
@kanushka kanushka added this to the 2201.3.3 milestone Feb 20, 2023
@kanushka kanushka requested a review from tharindulak February 20, 2023 05:45
@madushajg madushajg merged commit 68476ff into ballerina-platform:2201.3.x Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants